-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese localizations #229
Conversation
@wiz when running the website locally I get this error:
So I changed the image sources links for the community page to go a level higher: You don't seem to have that problem. What am I missing? |
3842638
to
9f4a884
Compare
6775c1f
to
3ea2314
Compare
@m52go okay this PR is ready for review, preview at https://deploy-preview-229--bisq-website.netlify.com/ja/ Only 70% of strings are translated so far, but we want to ship this to prepare for the upcoming v1.1.6 release. We will submit remaining 30% of strings in another PR soon. |
@wiz you need to be careful with hyperlinks and make sure if there's space before and after. For example: https://www.transifex.com/bisq/bisq-website/translate/#ja/strings/174374865?q=text%3AGithub. |
@huey735 The Japanese language doesn't use spaces. |
@wiz Oh. It's something that has happened with most translations and some strings did look a little snuggled but never mind it them. |
ACK |
@huey735 no worries, yeah in most languages this would be a mistake, but in this case the spaces were intentionally removed. thanks everyone for reviewing and merging! 🎉 |
No description provided.