Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese localizations #229

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Add Japanese localizations #229

merged 2 commits into from
Sep 6, 2019

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Sep 5, 2019

No description provided.

@huey735
Copy link
Contributor

huey735 commented Sep 6, 2019

@wiz when running the website locally I get this error:

[2019-09-06 12:15:47] ERROR `/images/apple-touch-icon.png' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/github.svg' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/twitter.svg' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/youtube.svg' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/slack.svg' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/forum.svg' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/mailinglist.svg' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/irc.svg' not found.
[2019-09-06 12:15:52] ERROR `/de/images/community/reddit.svg' not found.

So I changed the image sources links for the community page to go a level higher:
img src="../images/community/github.svg" alt="github"
img src="../../images/community/github.svg" alt="github"

You don't seem to have that problem. What am I missing?

@wiz
Copy link
Contributor Author

wiz commented Sep 6, 2019

@huey735 the issue you've identified is not related to this PR, but I've submitted PR #235 to fix it

@wiz wiz force-pushed the japanese branch 2 times, most recently from 3842638 to 9f4a884 Compare September 6, 2019 15:42
@wiz wiz force-pushed the japanese branch 3 times, most recently from 6775c1f to 3ea2314 Compare September 6, 2019 16:41
@wiz wiz changed the title WIP on Japanese localization Add Japanese localizations Sep 6, 2019
@wiz
Copy link
Contributor Author

wiz commented Sep 6, 2019

@m52go okay this PR is ready for review, preview at https://deploy-preview-229--bisq-website.netlify.com/ja/

Only 70% of strings are translated so far, but we want to ship this to prepare for the upcoming v1.1.6 release. We will submit remaining 30% of strings in another PR soon.

@huey735
Copy link
Contributor

huey735 commented Sep 6, 2019

@wiz you need to be careful with hyperlinks and make sure if there's space before and after. For example: https://www.transifex.com/bisq/bisq-website/translate/#ja/strings/174374865?q=text%3AGithub.

@wiz
Copy link
Contributor Author

wiz commented Sep 6, 2019

@huey735 The Japanese language doesn't use spaces.

@huey735
Copy link
Contributor

huey735 commented Sep 6, 2019

@wiz Oh. It's something that has happened with most translations and some strings did look a little snuggled but never mind it them.

@m52go
Copy link
Contributor

m52go commented Sep 6, 2019

ACK

@m52go m52go merged commit ba73c75 into bisq-network:master Sep 6, 2019
@wiz wiz deleted the japanese branch September 6, 2019 17:25
@wiz
Copy link
Contributor Author

wiz commented Sep 6, 2019

@huey735 no worries, yeah in most languages this would be a mistake, but in this case the spaces were intentionally removed.

thanks everyone for reviewing and merging! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants